StaticImport

SUGGESTION

Simplification

Summary

Identifier should be statically imported

Suppression

Suppress false positives by adding the suppression annotation @SuppressWarnings("StaticImport") to the enclosing element.

Disable this pattern completely by adding -Xep:StaticImport:OFF as compiler argument. Learn more.

Samples

Replacement

Shows the difference in example code before and after the bug pattern is applied.

+import static com.google.common.collect.ImmutableMap.toImmutableMap;
+import static com.google.common.collect.ImmutableSet.toImmutableSet;
+import static com.google.errorprone.BugPattern.LinkType.NONE;
+import static com.google.errorprone.BugPattern.SeverityLevel.SUGGESTION;
+import static com.google.errorprone.BugPattern.StandardTags.SIMPLIFICATION;
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static java.util.Collections.disjoint;
+import static java.util.Collections.reverse;
+import static java.util.Objects.requireNonNull;
 import static java.util.function.Predicate.not;
+import static java.util.regex.Pattern.CASE_INSENSITIVE;
+import static org.junit.jupiter.params.provider.Arguments.arguments;
+import static org.springframework.boot.test.context.SpringBootTest.WebEnvironment.RANDOM_PORT;
+import static org.springframework.format.annotation.DateTimeFormat.ISO.DATE;
+import static org.springframework.format.annotation.DateTimeFormat.ISO.DATE_TIME;
+import static org.springframework.format.annotation.DateTimeFormat.ISO.TIME;
+import static org.springframework.http.MediaType.APPLICATION_XHTML_XML;
+import static org.springframework.http.MediaType.TEXT_HTML;
 
 import com.google.common.base.Predicates;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import com.google.errorprone.BugPattern;
 import com.google.errorprone.BugPattern.SeverityLevel;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Objects;
 import java.util.regex.Pattern;
 import org.junit.jupiter.params.provider.Arguments;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
 import org.springframework.format.annotation.DateTimeFormat;
 import org.springframework.format.annotation.DateTimeFormat.ISO;
 import org.springframework.http.MediaType;
 
 class A {
   void m1() {
-    ImmutableMap.toImmutableMap(v -> v, v -> v);
+    toImmutableMap(v -> v, v -> v);
     ImmutableMap.<String, String, String>toImmutableMap(v -> v, v -> v);
 
-    ImmutableSet.toImmutableSet();
+    toImmutableSet();
     ImmutableSet.<String>toImmutableSet();
 
-    Collections.disjoint(ImmutableSet.of(), ImmutableSet.of());
-    Collections.reverse(new ArrayList<>());
+    disjoint(ImmutableSet.of(), ImmutableSet.of());
+    reverse(new ArrayList<>());
 
     Predicates.not(null);
     not(null);
 
-    Arguments.arguments("foo");
+    arguments("foo");
 
-    Objects.requireNonNull("bar");
+    requireNonNull("bar");
 
-    Object o = StandardCharsets.UTF_8;
+    Object o = UTF_8;
 
     ImmutableSet.of(
-        MediaType.ALL,
-        MediaType.APPLICATION_XHTML_XML,
-        MediaType.TEXT_HTML,
-        MediaType.valueOf("image/webp"));
+        MediaType.ALL, APPLICATION_XHTML_XML, TEXT_HTML, MediaType.valueOf("image/webp"));
 
-    Pattern.compile("", Pattern.CASE_INSENSITIVE);
+    Pattern.compile("", CASE_INSENSITIVE);
   }
 
   void m2(
-      @DateTimeFormat(iso = DateTimeFormat.ISO.DATE) String date,
-      @DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME) String dateTime,
-      @DateTimeFormat(iso = DateTimeFormat.ISO.TIME) String time) {}
+      @DateTimeFormat(iso = DATE) String date,
+      @DateTimeFormat(iso = DATE_TIME) String dateTime,
+      @DateTimeFormat(iso = TIME) String time) {}
 
   void m3(
-      @DateTimeFormat(iso = ISO.DATE) String date,
-      @DateTimeFormat(iso = ISO.DATE_TIME) String dateTime,
-      @DateTimeFormat(iso = ISO.TIME) String time) {}
-
-  @BugPattern(
-      summary = "",
-      linkType = BugPattern.LinkType.NONE,
-      severity = SeverityLevel.SUGGESTION,
-      tags = BugPattern.StandardTags.SIMPLIFICATION)
+      @DateTimeFormat(iso = DATE) String date,
+      @DateTimeFormat(iso = DATE_TIME) String dateTime,
+      @DateTimeFormat(iso = TIME) String time) {}
+
+  @BugPattern(summary = "", linkType = NONE, severity = SUGGESTION, tags = SIMPLIFICATION)
   static final class TestBugPattern {}
 
-  @SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)
+  @SpringBootTest(webEnvironment = RANDOM_PORT)
   final class Test {}
 }

Identification

Shows code lines which will (not) be flagged by this bug pattern.
A //BUG: Diagnostic contains: comment is placed above any violating line.

import static com.google.common.collect.ImmutableMap.toImmutableMap;
import static com.google.common.collect.ImmutableSet.toImmutableSet;
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.function.Predicate.not;
import static org.springframework.boot.test.context.SpringBootTest.WebEnvironment.RANDOM_PORT;

import com.google.common.base.Predicates;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableMultiset;
import com.google.common.collect.ImmutableSet;
import com.google.errorprone.refaster.ImportPolicy;
import com.google.errorprone.refaster.annotation.UseImportPolicy;
import java.nio.charset.StandardCharsets;
import java.time.ZoneOffset;
import java.util.Optional;
import java.util.UUID;
import java.util.function.Predicate;
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
import org.springframework.http.MediaType;

class A {
  void m() {
    // BUG: Diagnostic contains:
    ImmutableMap.toImmutableMap(v -> v, v -> v);
    ImmutableMap.<String, String, String>toImmutableMap(v -> v, v -> v);
    toImmutableMap(v -> v, v -> v);

    // BUG: Diagnostic contains:
    ImmutableSet.toImmutableSet();
    ImmutableSet.<String>toImmutableSet();
    toImmutableSet();

    // Not flagged because we define `#toImmutableMultiset` below.
    ImmutableMultiset.toImmutableMultiset();
    ImmutableMultiset.<String>toImmutableMultiset();
    toImmutableMultiset();

    // BUG: Diagnostic contains:
    Predicate.not(null);
    not(null);

    // BUG: Diagnostic contains:
    Predicates.alwaysTrue();
    // BUG: Diagnostic contains:
    Predicates.alwaysFalse();
    // Not flagged because of `java.util.function.Predicate.not` import.
    Predicates.not(null);

    // BUG: Diagnostic contains:
    UUID uuid = UUID.randomUUID();

    // BUG: Diagnostic contains:
    Object o1 = StandardCharsets.UTF_8;
    Object o2 = UTF_8;

    // BUG: Diagnostic contains:
    Object e1 = WebEnvironment.RANDOM_PORT;
    Object e2 = RANDOM_PORT;

    // Not flagged because `MediaType.ALL` is exempted.
    MediaType t1 = MediaType.ALL;
    // BUG: Diagnostic contains:
    MediaType t2 = MediaType.APPLICATION_JSON;

    Optional.empty();

    // BUG: Diagnostic contains:
    ZoneOffset zo1 = ZoneOffset.UTC;
    ZoneOffset zo2 = ZoneOffset.MIN;
  }

  // BUG: Diagnostic contains:
  @UseImportPolicy(ImportPolicy.IMPORT_TOP_LEVEL)
  void refasterAfterTemplate() {}

  void toImmutableMultiset() {}
}